Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive QR Code Component

FilipCichowskiβ€’ 20

@FilipCichowski

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


  • How can I improve HTML structure to make this component more accesible?
  • How can I optimize my CSS in this project?
  • Can you reccomend any good practices I shoul follow while creating similar things?

Community feedback

Ferβ€’ 3,970

@fernandolapaz

Posted

Hi πŸ‘‹, I leave you some tips that may interest you:

  • It is convenient to separate the code in different files (html, css) for a better organization and easier maintenance.

HTML 🧱, ACCESSIBILITY βš–:

  • The main content of every page (the card in this case) should be wrapped with the <main> tag.

CSS 🎨:

  • It is better to use min-height: 100vh; for the body, as using height causes the page to be cut off in viewports with small height (such as mobile landscape orientation).
  • You don't need to use font-weight of 400 and 700 as these are the default values for normal and bold fonts (paragraphs and headings).
  • You might consider using relative units like rem or em since they are a better option for scalable layouts. Pixels may not be the best alternative because absolute units don’t scale. You could easily start converting to rem (1 rem equals the font size of the root element, 16px by default).

I hope you find it useful, any questions do not hesitate πŸ™‚

Regards,

Marked as helpful

0

FilipCichowskiβ€’ 20

@FilipCichowski

Posted

@fernandolapaz Thank you for your feedback! I modified my code according to it.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord