Design comparison
SolutionDesign
Community feedback
- @0xabdulkhaliqPosted about 1 year ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
QR iMAGE ALT TEXT 📸:
- Since this component involves scanning the QR code, the image is not a decoration, so it must have an
alt
attribute.
- The
alt
attribute should explain the purpose of theimage
.
- E.g.
alt="QR code to frontendmentor.io"
<img class="qr" src="./images/image-qr-code.png" alt="QR code to frontendmentor.io">
- Once again, please do update the
PREVIEW SITE
Link fromhttps://vickygbonorino.github.io/
tohttps://vickygbonorino.github.io/qr-component/
. It will helps fellow reviewers to review your code.
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
Marked as helpful0@vickygbonorinoPosted about 1 year ago@0xAbdulKhalid yes! I noticed that latter. Thank you!!
0 - @covolanPosted about 1 year ago
Hey vickygbonorino 👋
Nice work!
Just one thing, the github pages on the solution is wrong. The correct one would be:
https://vickygbonorino.github.io/qr-component/
Congrats on your first challenge complete!🎉
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord