Skip to content
Submitted about 1 year ago

Responsive QR code Component

HooriaSaeeda•120
@HooriaSaeeda
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • Øystein Håberg•10,710
    @Islandstone89Posted about 1 year ago

    Hi, well done. Here are a few suggestions to make it even better.

    HTML:

    • The image needs alt text. The alt text should describe the content, and in this case, where it leads. Don't include words like "photo" or "image".

    CSS:

    • You should preferably write the CSS in a separate file, and link to it in the <head>.

    • It's considered best practice to write the mobile styles as default, then use media queries for desktop/tablet. Media queries should be in REM.

    • Font-size must never be in pixels. Use REMs instead.

    • <height> should be <min-height>. This allows the <main> to grow beyond the viewport.

    • Remove all fixed widths. You could set a max-width on the card, once again in REMs.

    Hope this helps!

    Marked as helpful
    0
    HooriaSaeeda•120
    @HooriaSaeedaPosted about 1 year ago

    @Islandstone89 Thank you for your feedback.

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord