Responsive QR Code Component

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi Dyntbn, good job! I took some time to look at your code and have some ideas for improving it:

  • add main tag and wrap the card for improve the Accessibility
  • remove all unnecessary code, the less you write the better as well as being clearer: for example the div container of image
  • remove all margin from card class
  • try to use flexbox to the body for center the card. Read here -> best flex guide
  • after, add min-height: 100vh to body because Flexbox aligns child items to the size of the parent container

  Overall you did well 😉

  Hope this help and happy coding!

  Marked as helpful

  1

  ---

  

  Joshua•130

  @dyntbnPosted over 2 years ago

  @denielden

  Woah! That min-height property with flexbox combination is pretty neat, I'm definitely using that for future projects. 🤯

  I'll start working in those changes you mentioned right now. I also took a look at your profile, and I appreciate what you're doing Deniel, thank you!

  1

  

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  @dyntbn You are welcome and thanks! Keep it up :)

  1