Responsive Qr Code component

Community feedback

• 

  Boris•2,870

  @mkborisPosted 3 months ago

  Hi NaoMauss, great job completing your first challenge, here are a few things you can improve on your work

  • All content should be wrapped within landmarks. Wrap a main tag around the container
  • Just one h1 element is enough for this. The heading is a single sentence
  • You don't need to create an empty div to separate two elements, you can use margin for that
  • It's best practice linking Google fonts directly in the HTML head section rather than directly in your CSS file as it enables asynchronous downloading, improving page load times. Consider using a modern CSS reset at the start of the styles in every project. Like this one Modern CSS Reset. This will help reset a list of default browser styles.
  • Font-size should be written in rem not px

  0