P
John Davidson• 210
@John-Davidson-8
Posted
Excellent job, looks amazing.
0
Design comparison
Solution retrospective
What are you most proud of, and what would you do differently next time?
this was a quick one, but I am proud that I did not have to google for syntax or css props
What challenges did you encounter, and how did you overcome them?
Understanding the Figma images was new to me
What specific areas of your project would you like help with?
NA
Community feedback
@kinqbert
Posted
Looks fine to me! However, personally, I'd recommend some improvements:
- You can set
text-align: center;for the whole card, not to each element of the card (like title, description, etc.), every text inside of it will be alligned to the center. - [Not critical] Don't forget about paddings, don't use margins only. It would be more convenient to set padding of 16 pixels for the every card side.
- [Not critical] You can use
padding-inline: 16px;instead ofpadding: 0 16px; - [Not critical] You should use class names instead of just tags as CSS selectors (e.g:
.card-title, not.card h1). It doesn't makes any weather in such project, but I believe it would make code more readable in bigger project.
Great work! Love your solution!
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord