Responsive QR Code Component

Community feedback

• 

  YOPA SEREINA•100

  @BRENHINESPosted about 1 year ago

  Hello, your code is well written. As for how to do CSS resets more simply, I don't think there is a simpler way to do it. But if you fond another way to make it simply, please can you share it ? And flex is the simplest way to center a div.

  Your Html is quite semantic but the classes names, I find them a little disorganized and non-specific, have you ever tried to learn the formatting of class names?

  For SEO you should have an H1 for the title because it will be more referenced.

  Best wishes.

  Marked as helpful

  2

  ---

  

  2trill2code•70

  @2trill2codePosted about 1 year ago

  @BRENHINES Yeah I don't really know what to name the classes, but I'll do some research. Appreciate your response :)

  0

  

  YOPA SEREINA•100

  @BRENHINESPosted about 1 year ago

  @2trill2code you can read this at least, it's help me a little beat. https://www.freecodecamp.org/news/css-naming-conventions-that-will-save-you-hours-of-debugging-35cea737d849/

  1
• 

  myrh•100

  @myrhisyoinkedPosted about 1 year ago

  I prefer to use this method to center container vertically & horizontally

  body {
    display: grid;
    place-content: center;
    margin: 0;
    min-height: 100vh;
  }
  

  1

  ---

  

  YOPA SEREINA•100

  @BRENHINESPosted about 1 year ago

  @myrhisyoinked Ah thanks, I known this other methode but i use frequently Flexbox because with it position my objets where i want. It's better when you want to center vertically and to put it left horizontally. So you can manage your object as you want.

  0