Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive QR Code Component

@2trill2code

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


  • Are there better ways to do a simple CSS reset?
  • Is there a better way to vertically and horizontally centre a div?
  • How was the HTML? Was it semantic enough? How about the class names were they also semantic?
  • Should all text type elements p, h1 etc. have class names?
  • Is it a good practice to specify something like h3 compared to .container h3 if you know that one h3 will be on the page?

Community feedback

@BRENHINES

Posted

Hello, your code is well written. As for how to do CSS resets more simply, I don't think there is a simpler way to do it. But if you fond another way to make it simply, please can you share it ? And flex is the simplest way to center a div.

Your Html is quite semantic but the classes names, I find them a little disorganized and non-specific, have you ever tried to learn the formatting of class names?

For SEO you should have an H1 for the title because it will be more referenced.

Best wishes.

Marked as helpful

2

@2trill2code

Posted

@BRENHINES Yeah I don't really know what to name the classes, but I'll do some research. Appreciate your response :)

0

@BRENHINES

Posted

@2trill2code you can read this at least, it's help me a little beat. https://www.freecodecamp.org/news/css-naming-conventions-that-will-save-you-hours-of-debugging-35cea737d849/

1
myrh 100

@myrhisyoinked

Posted

I prefer to use this method to center container vertically & horizontally

body {
  display: grid;
  place-content: center;
  margin: 0;
  min-height: 100vh;
}
1

@BRENHINES

Posted

@myrhisyoinked Ah thanks, I known this other methode but i use frequently Flexbox because with it position my objets where i want. It's better when you want to center vertically and to put it left horizontally. So you can manage your object as you want.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord