Responsive qr code component

Community feedback

• 

  JunoField•310

  @JunoFieldPosted over 2 years ago

  Hi,

  Congrats on completing the project. Some things that come to mind:

  • On the "Improve your fr..." section, your font size is much too large. Just decreasing this would make a big difference to the page's appearance.
  • Your centre card and QR code currently have black borders - to disable this, simply add border: none; to the CSS for those sections.
  • Element IDs should be named descriptively - names like wrapper are a big no-go. Instead use names like centre-card, text-section, etc.
  • There's a few HTML and accessibility issues - I'll leave you to work those out, as it's good experience to solve those yourself (with the help of Google).
  • Once you've made these main changes, play around with margins, padding, etc. to get it looking as close to the design as possible.

  Good luck!

  0

  ---

  

  adbansode•30

  @adbansodePosted over 2 years ago

  @JunoField Hi Thanks for the feedback.

  1