Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive QR code component

abhijeet 30

@imabhijeet

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hey folks, I want you all to review my solutions. Any suggestion and feedbacks on this will be helpful for me.

Community feedback

@Enmanuel-Otero-Montano

Posted

Hello @imabhijeet!

Congratulations on completing the challenge. Your solution looks good, but I've looked at your code and would like to make an important improvement suggestion.

The suggestion is that you apply semantic tags in HTML, you have done everything with <div> and this is not good, with semantic tags I mean that you use <main>, the <h1> tags to the <h6>, <section>, <article>, these are just a few, there are more. The use of semantic tags is very important in web development, since they help browsers better understand how your website is structured, which translates into a more accessible website, improved web positioning and other improvements. I encourage you to search for information on the subject.

Greetings and keep practicing

Marked as helpful

1

abhijeet 30

@imabhijeet

Posted

Thankyou @Enmanuel-Otero-Montano for your suggestion. I will definitely look into this.

0
Daniel 🛸 44,230

@danielmrz-dev

Posted

Hello @imabhijeet!

Your project looks excelent!

I just have two minor suggestions for you to improve it:

  • The font-family used in this project is Outfit. You can always check the style-guide file to see what are the recommended fonts and colors for the project.

  • Also, your box-shadow is a bit darker than the original design. I tried some values and updated your code, here it is, in case you wanna change it:

box-shadow: 1px 1px 42px hsl(219, 27%, 73%);

I hope it helps!

Other than those details, you did a great job!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord