Responsive QR Code Component

Community feedback

• 

  P

  Øystein Håberg•10,710

  @Islandstone89Posted 8 months ago

  HTML:

  • Remove .container, it is not needed.

  • The alt text must also say where it leads(frontendmentor.io).

  CSS:

  • Including a CSS Reset at the top is good practice.

  • Add around 1rem of padding on the body, so the card doesn't touch the edges on small screens.

  • On the body, change height to min-height - this way, the content will not get cut off if it grows beneath the viewport.

  • Add the following to body:

  justify-content: center;
  align-items: center;
  min-height: 100svh;
  

  • Remove the styles on main, they are not needed.

  • Remove the margin on the card.

  • Add a max-width of around 20rem on the card, to prevent it from getting too wide on larger screens.

  • font-size must never be in px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead.

  • line-height and letter-spacing must also never be in px.

  • Since all of the text should be centered, you only need to set text-align: center on the body, and remove it elsewhere. The children will inherit the value.

  • Paragraphs have a default value of font-weight: 400, so there is no need to declare it.

  • On the image, add display: block and change width to max-width: 100% - the max-width prevents it from overflowing its container.

  • You don't need to declare font-style: normal, as that is the default.

  1