Responsive QR code challenge, with semantic HTML, CSS
Design comparison
Solution retrospective
Following a design from start to finish
What challenges did you encounter, and how did you overcome them?No challenges for this particular project
What specific areas of your project would you like help with?Writing semantic and efficient code
Community feedback
- @danielmrz-devPosted 10 months ago
Hello @thisispeterj!
Your solution looks excellent!
I have just one suggestion:
- Use
<main>to wrap the main content instead of<main>and<article>.
š The tag
<article>would make more sense if the card was part of a bigger website (in certainly would in real world), but here it is all we have on the screen.This tag change does not impact your project visually and makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.
I hope it helps!
Other than that, great job!
Marked as helpful0@thisispeterjPosted 10 months agoHi @danielmrz-dev Thank you for the suggestion, I will use this going forward. I wasn't sure on when to use the article and section tags, this clears that up for me.
Happy Coding :)
0 - Use
- @danielmrz-devPosted 10 months ago
Hello @thisispeterj!
Your solution looks excellent!
I have just one suggestion:
- Use
<main>to wrap the main content instead of<main>and<article>.
š The tag
<article>would make more sense if the card was part of a bigger website (in certainly would in real world), but here it is all we have on the screen.This tag change does not impact your project visually and makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.
I hope it helps!
Other than that, great job!
0 - Use
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord