Responsive qr-code challenge solution using flexbox CSS

Community feedback

• 

  P

  Øystein Håberg•10,390

  @Islandstone89Posted 3 months ago

  HTML:

  • The <main> element holds all of the content on a page, except for the header and the footer. The card would likely not be the only component on a page, hence I would wrap it in a <div class="card"> inside of <main>.

  • The alt text must also say where it leads(the frontendmentor website). A good alt text would be "QR code leading to the Frontend Mentor website."

  • I would change the heading to a <h2> - a page should only have one <h1>, reserved for the main heading. As this is a card heading, it would likely not be the main heading on a page with several components.

  • .attribution should be a <footer>, and you should use <p> for the text inside. The footer must be placed outside of the main.

  CSS:

  • I like to add 1rem of padding on the body, to ensure the card doesn't touch the edges on small screens.

  • On the body, change height to min-height - this way, the content will not get cut off if it grows beneath the viewport.

  • Remove the margin on the card.

  • Add flex-direction: column and gap: 2rem on body.

  • Remove all widths in px.

  • Add a max-width of around 20rem on the card, to prevent it from getting too wide on larger screens.

  • font-size must never be in px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead.

  • Change the color of the paragraph. It has a contrast ratio of 2.7 / 1, which doesn't fulfill the Web Content Accessibility Guidelines AA Requirement. For regular text, the contrast ratio must be at least 4.5 / 1. For simplicity, you can just use the heading color, which is much darker.

  • Since all of the text should be centered, you only need to set text-align: center on the body, and remove it elsewhere. The children will inherit the value.

  • On the image, add display: block and change width to max-width: 100% - the max-width prevents it from overflowing its container.

  • As the design doesn't change, there is no need for any media queries. When you do need them, they should be in rem or em, not px. Also, it is common practice to do mobile styles first and use media queries for larger screens.

  0
• 

  Samantha Jowa•40

  @SamanthaJowaPosted 3 months ago

  Your implementation was well executed. Well done! However, you could have paid more attention to the sizing of your elements. Overall I think it's great. I also took a few notes from your code

  0