Design comparison
Community feedback
- @JhonyDomingosPosted about 2 years ago
Hey congratulations for your solution 🎉🎉 Here are a few tips that I've received from my solution that works very well
-
Replace the
<h2>
containing the main title with<h1>
note that this title is the main heading for this page and every page needs oneh1
to show which is the most important heading. Use the sequenceh1 h2 h3 h4 h5
to show the hierarchy of your titles in the level of importance, never jump a level. -
Use relative units as
rem
or em instead ofpx
to improve your performance by resizing fonts between different screens and devices. These units are better to make your website more accessible.REM
does not just apply to font size, but to all sizes as well. -
Use
<main>
instead of<div>
to wrap the card container. This way you show that this is the main block of content and also replace the div with a semantic tag. -
Put an
alt
value<img>
tag to improve the accessibility. -
There are a few things that you can put on your code as you wish!!
Great solution 👍
Marked as helpful2 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord