Responsive QR Code Card using basic HTML, CSS

Community feedback

• 

  P

  Øystein Håberg•10,390

  @Islandstone89Posted 8 months ago

  HTML:

  • Remove the empty ````, and its text must be wrapped in a <p>.

  CSS:

  • It's good practice to include a CSS Reset at the top.

  • Remove height: 100% on html and body.

  • Remove display and margin on html.

  • Add around 1rem of padding on the body, so the card doesn't touch the edges on small screens.

  • Remove display, vertical-align and margin from body.

  • Remove display: block on the card. It is a block element by default.

  • Remove the margin on the card.

  • To center the card horizontally and vertically, use Flexbox on the body:

  display: flex;
  flex-direction: column;
  justify-content: center;
  align-items: center;
  min-height: 100svh;
  

  • Remove the width on the card.

  • Add a max-width of around 20rem on the card, to prevent it from getting too wide on larger screens.

  • font-size must never be in px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead.

  • Since all of the text should be centered, you only need to set text-align: center on the body, and remove it elsewhere. The children will inherit the value.

  • On the image, add display: block and change width to max-width: 100% - the max-width prevents it from overflowing its container.

  • Remove #new-ft:hover, as you don't have any elements with that ID in your HTML.

  Marked as helpful

  0

  ---

  

  P

  Øystein Håberg•10,390

  @Islandstone89Posted 8 months ago

  Not sure what happened with my HTML section... what I intended to say:

  • Remove the empty style tags.

  • The image has meaning, so it must have proper alt text. Write something short and descriptive, without including words like "image" or "photo". Screen readers start announcing images with "image", so an alt text of "image of qr code" would be read like this: "image, image of qr code". The alt text must also say where it leads(frontendmentor.io).

  • .attribution should be a <footer>, and its text must be wrapped in a <p>.

  Marked as helpful

  0

  

  Thi Lam•70

  @zoetlamPosted 8 months ago

  Hi @Islandstone89, I'm very appreciate about your feedback . I'm pretty struggle to center those <main> tag, your code really helps me. I will definitely try this, and fix my code to improve my skill. Thank you so much for your advice. Wish you well and have a nice day!

  1