Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive qr code card

@arudu

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I found changing picture size to match up with card difficult Looking for any type of feedback and to get better

Community feedback

Adriano 34,090

@AdrianoEscarabote

Posted

Hi Paul Janne, how are you?

Welcome to the front-end mentor community!

I really liked the result of your project, but I have some tips that I think you will enjoy:

  • every Html document must contain the main tag, so we can identify the main content, to fix this, wrap all the content with the main tag. HTML5 landmark elements are used to improve navigation experience on your site for users of assistive technology.
  • To align some content in the center of the screen, always prefer to use display: flex; it will make the layout more responsive!

Example:

body {
    margin: 0;
    padding: 0;
    display: flex;
    align-items: center;
    justify-content: center;
    min-height: 100vh;
}

The rest is great!

I hope it helps... 👍

0
Declan 220

@engelbrechtz

Posted

Well Done!!!

Looking, Good Man.

Changes to consider. Prior to reading, you're CSS code. I came across that you copy and paste colour codes throughout the script. Try using this instead :)

  • Apply the text-align: center; property to class card which acts as you're container.
  • Apply width: 90%; to you're img element.
:root{
     --color-for-box: white;
     --color-for-box2: red;
     --color-for-box3: yellow;
     --color-for-box4: green;
}

this creates a variable for you to call upon more than once without needing to copy the givin hex colour code twice.

Overall, everything is looking awesome.

Regards, Declan.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord