Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive QR Code Begginer Challenge

Mcnafahaβ€’ 240

@TheMcnafaha

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Is my semantic HTML correct? I had a few second thoughts about labeling my heading-levels due to the short nature of the HTML. Particularly, I'm about 70% sure that labeling the attribution section as an article with a H2 heading was the right move. I'm about 50% sure that it was the best move though.

Community feedback

Abdul Khaliq πŸš€β€’ 72,660

@0xabdulkhaliq

Posted

Hello there πŸ‘‹. Congratulations on successfully completing the challenge! πŸŽ‰

  • I have other recommendations regarding your code that I believe will be of great interest to you.

CSS 🎨:

  • Looks like the attribution element has been placed bottom using margin. So let me explain, How you can place the component at bottom with using fixed positioning for footer
  • Luckily you already used Flex layout of css to center the component, So you just want to add fixed position for <footer> element to place it in bottom of the page
footer {
position: fixed;
bottom: 1em;
}
  • Now remove these styles, after removing you can able to see the changes
.attribution {
margin: 0 auto;
margin-top: 1em;
}
  • Now your component has been properly at bottom

.

I hope you find this helpful πŸ˜„ Above all, the solution you submitted is great !

Happy coding!

Marked as helpful

1

@Kamlesh0007

Posted

Congratulations on completing the challenge! πŸŽ‰That's a great achievement, and I'm sure you put a lot of effort into it. I really liked the way you approached the challenge and the code you wrote. You demonstrated a good understanding of the concepts and applied them effectively to solve the problem.I have a few suggestions to improve your code further. You need to add background color to body tag to make background as per design

body
{
background:hsl(212, 45%, 89%);
}

remove background from bigcontainer class

Marked as helpful

1

Mcnafahaβ€’ 240

@TheMcnafaha

Posted

Thanks for the feedback!!! I originally thought that the design called for a background like they used here. Reading your comment and checking out other Frontend Mentor challenges made me see this was not the case. @Kamlesh0007

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord