Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive QR-code

Sunvic567 40

@Sunvic567

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

P

@Jomagene

Posted

Hi @Sunvic567,

I noticed a few areas where you could enhance your code:

Code Improvement

  1. Use Semantic HTML: Try using semantic tags like <main>, <section>, etc., instead of relying solely on <div> tags. This improves the accessibility and readability of your code.

  2. Remove Comments: It’s best to remove comments from the HTML file before deployment, as they will be visible to visitors and can cause confusion.

  3. Font Family: The specified font-family should be Outfit. Currently, it looks like you’re using Georgia, 'Times New Roman', Times, serif. Please update it to use Outfit.

Styling Improvements

  1. Centering: Ensure the container is centered vertically for a better visual layout.
  2. Background Color: Adjust the background color of the body to match the design specifications. (use hsl(212, 45%, 89%) instead of rgb(219, 219, 243))

Great job so far, and keep up the good work!

Marked as helpful

0

Sunvic567 40

@Sunvic567

Posted

Thnaks@Jomagene

0
P

@Jomagene

Posted

You're welcome, @Sunvic567! Keep it up!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord