Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive QR Code

Jennifer 70

@jenieg

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


What are you most proud of, and what would you do differently next time?

Being able to get the responsiveness was a fun challenge

What challenges did you encounter, and how did you overcome them?

Having the component stay centered with flexbox while maintaining responsiveness was something that took a little bit of research.

What specific areas of your project would you like help with?

I would love to come back and try these challenges with something like Tailwind rather than plain CSS.

Community feedback

P

@Islandstone89

Posted

HTML:

  • Every webpage needs a <main> that wraps all of the content, except for <header> and footer>. This is vital for accessibility, as it helps screen readers identify a page's "main" section. Change .container into a <main>.

  • The alt text must also say where it leads(frontendmentor website). A good alt text would be "QR code leading to the Frontend Mentor website."

  • As this is a card heading, it would probably not be the main heading on a webpage. Hence, I would change it to a <h2>.

CSS:

  • I'm not sure how much normalize.css is used nowadays. I like to use this CSS reset from Andy Bell.

  • You don't need the .clear or .clearfix, so remove those.

  • I like to add 1rem of padding on the body, to ensure the card doesn't touch the edges on small screens.

  • I would remove the margin on the card, and center the card horizontally using Flexbox. Add justify-content on .container. height should be min-height - we never want to limit the height of text elements, as that would cause overflow if we have enough text.

  • Remove all widths.

  • Add a max-width of around 20rem on the card, to prevent it from getting too wide on larger screens.

  • font-size must never be in px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead.

  • On the image, add display: block and max-width: 100% - the max-width prevents it from overflowing its container. Remove margin-top.

  • To create the space between the image and the edge of the card, set padding on all 4 sides of the card:padding: 1rem.

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord