Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive QR code

@FranPetkovic

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I appreciate the feedback

Community feedback

Vanza Setia 27,795

@vanzasetia

Posted

Greetings, Fran! 👋

Great work on this challenge! Your solution looks pretty good! 😀

I notice that there's a media query in the stylesheet which can be removed. It's only repeating the max-width property which has been declared at line number 22.

The image content is the most important content of the site. So, I highly suggest adding some alternative text to it. Alternative text like, "QR code for frontendmentor.io" would be good.

Lastly, I wouldn't recommend limitting the height of the body element, it will not allow the users to scroll the page if the page content needs more height. Use min-height instead.

Hope this helps.

Marked as helpful

2

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord