responsive qr code

Community feedback

• 

  Alex•3,130

  @Alex-Archer-IPosted 4 months ago

  Hi!

  Congrats with your first challenge, that's cool =)

  I can give a few tips.

  • You can style image directly, without wrapping it in the div. Also there is no need to set height for it as images adjusts their proportions.
  • Every page should contain main tag. You can use it instead div wrapper.
  • I recommend you to use min-height instead height for body tag. That way it could stretch in cases if content would be bigger than screen size.
  • It is good idea to make the width of the container responsive too. You can do it with max-width property.
  • For font sizes it's better to use rem instead of pixels. It's a special values which depends on users font settings.

  So, hope that could helps =) Good luck, keep doing cool stuff =)

  0

  ---

  

  Satty90•10

  @Satty90Posted 4 months ago

  @Alex-Archer-I Thank you so much Alex I will implement the tips in the next challenge

  1

  

  Alex•3,130

  @Alex-Archer-IPosted 4 months ago

  @Satty90

  You're welcome =) Fell free to ask anything if need =)

  0