@Islandstone89
Posted
HTML:
-
Every webpage needs a
<main>that wraps all of the content, except for<header>andfooter>. This is vital for accessibility, as it helps screen readers identify a page's "main" section. Wrap.containerin a<main>. -
The image has meaning, so it must have proper alt text. Write something short and descriptive, without including words like "image" or "photo". Screen readers start announcing images with "image", so an alt text of "image of qr code" would be read like this: "image, image of qr code". The alt text must also say where it leads(frontendmentor.io).
-
Headings should always be in order, so you never start with a
<h3>. Change it into a<h1>. -
.attributionshould be a<footer>, and you should use<p>for the text inside.
CSS:
-
It is best practice to write CSS in a separate file, often called
style.css. Create one in the same folder as theindex.html, and link to it in the<head>:<link rel="stylesheet" href="style.css">. -
Including a CSS Reset at the top is good practice.
-
Use the style guide to find the correct
font-family. -
Add around
1remofpaddingon thebody, so the card doesn't touch the edges on small screens. -
Remove the margin on the card.
-
Add
min-height: 100svhandgap: 2remon thebody. -
Remove all widths and heights.
-
Add a
max-widthof around20remon the card, to prevent it from getting too wide on larger screens. -
font-sizemust never be in px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead. -
Since all of the text should be centered, you only need to set
text-align: centeron the body, and remove it elsewhere. The children will inherit the value. -
On the image, add
display: blockandmax-width: 100%- the max-width prevents it from overflowing its container. -
As the design doesn't change, there is no need for any media queries. When you do need them, they should be in rem, not px. Also, it is common practice to do mobile styles first and use media queries for larger screens.
Marked as helpful
@diksha-singh-17
Posted
Hey,@Islandstone89 I appreciate your code review! Your insights and suggestions are valuable to me. I'll go through each point you mentioned and make the necessary improvements.
