Design comparison
SolutionDesign
Community feedback
- @mubizzyPosted over 2 years ago
Excellent job on this challenge! your report has a few issues though:
-
wrap everything in your body in
<main>
or use semantics -
it is a best practice to use both HTML 5 and ARIA landmarks to ensure all content is contained within a navigational region.
Hope it helps:)...don't forget to mark it as helpful 👍
0 -
- @fatlindshehuPosted over 2 years ago
Hi there, Nice work with the component, even though I would recommend some changes:
- Center the component using flex;
- On the
body
setheight: 100vh
in order for vertical alignment to work. body { display: flex; justify-content: center; align-items: center;}
to center the component.- Make sure to remove the margin on the card.
Keep it up & happy coding...
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord