Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive QR

@DoppelGanger11

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Dylan 290

@dquinn089

Posted

Looks great and gets the job done! I have a suggestion to clean up your code and have it looking nicer.

Instead of giving every tag a class, you can just reference the specific tag directly.

Example: Instead of: <img src="images/image-qr-code.png" class="img"> Remove the class and do: <img src="images/image-qr-code.png">

CSS before: .img {} CSS after: img {}

Using class/id should really be reserved for when multiple div classes are being used which need to be identified for reference, as well as to reference any tag names within that specific class/id.

Example: If you had two div classes, and each one has an "img" tag, it would look something like this

.class_1 img{}

.class_2 img{}

I hope this is helpful and gives some insight on cleaner code and helps save some time!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord