responsive project created with react, react-router v6, and js

Community feedback

• 

  Damjan•220

  @iDamjanPosted over 1 year ago

  Overall it looks fine to me. I would suggest though minor things, which are mostly preference.

  Don't leave console log in a code and actually do something with the error, maybe set some boolean state and display error message on the screen. One thing i would do also to add a general loader everywhere, which will be handled by the loadData() function in a finnaly block after the catch so: catch(e) {setError(true)} finally {setLoading(false}.

  I would also add better naming, because i think most of the things are not very clear. and maybe styled components in a separate folder outside everything, which i think its a prefered way of using styled components.

  Let me know if this makes sense. Overall i really like the project, my version when i was doing this was a total trash :)))

  Marked as helpful

  0

  ---

  

  Stalin•410

  @StalinAMPosted over 1 year ago

  @iDamjan thank you for your comments, can you give me some examples of good names to describe better, thank you

  0