P
VictorGerfaud• 210
@JamesLaviron
Posted
- Does the solution include semantic HTML?
Yes it does, maybe you could add main or section tag.
- Is it accessible, and what improvements could be made?
Looks great.
- Does the layout look good on a range of screen sizes?
Yes it is but you should remove useless attribution to match screenshot.
- Is the code well-structured, readable, and reusable?
You should avoid common tags selectors such as h1 styling. When doing this, browsers will get all h1 and for each h1 will check ancestor. Performances could be lowered on big sites :( Otherwise nice ideas!
- Does the solution differ considerably from the design?
Nope, apart from padding on main div.
0
