Design comparison
Solution retrospective
I was able to finish this project fast. Now I understand that all those studying and coding are paying off. But still there is room for improvements , like being to understand scss better , this was my first time using it
What challenges did you encounter, and how did you overcome them?I was having some problems trying to use scss , like how to use it in raw HTML . I found the solutions from their documentations and stack overflow
Community feedback
- @JamesLavironPosted 4 months ago
- Does the solution include semantic HTML?
Yes it does, maybe you could add
main
orsection
tag.- Is it accessible, and what improvements could be made?
Looks great.
- Does the layout look good on a range of screen sizes?
Yes it is but you should remove useless attribution to match screenshot.
- Is the code well-structured, readable, and reusable?
You should avoid common tags selectors such as
h1
styling. When doing this, browsers will get allh1
and for eachh1
will check ancestor. Performances could be lowered on big sites :( Otherwise nice ideas!- Does the solution differ considerably from the design?
Nope, apart from padding on main div.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord