Responsive Profile Card Using Scss & Flex

Community feedback

• 

  Raymart Pamplona•16,100

  @pikapikamartPosted over 3 years ago

  Hey, great work on this one. Layout is good.

  Some suggestions would be that:

  1. On your body tag, instead of using height: 100vh use min-height: 100vh. Using height: 100vh will make the body tag have 100% of the remaining viewport's screen right, so this will limit its size IF there are many elements. Using min-height: 100vh will make sure it will have minimum of 100vh and will expand if it needs to. Also add padding to the top and bottom of the body to prevent touching the ceiling and flooring.

  2. The 3 stats at the bottom could have used ul since they are just list of different statistics of the user.

  3. If you want, you could add some sr-only contents, like a heading that will be read from assistive tech like "Profile Card" like that, so that other user will have an idea of what this is.

  But still, really good job on this ^^

  0

  ---

  

  Alif2001•70

  @Rafi8811Posted over 3 years ago

  @pikamart thank you very much for the suggestions :)

  0