Responsive profile card page with html & css

Community feedback

• 

  Web Frog•1,840

  @MasterDev333Posted almost 4 years ago

  Great work! It's a little tricky to positioning background circles in this challenge, but you did it well. It would be better if you make your class names more readable. Please take a look BEM naming conventions if you have time. Hope it helps. Happy coding~ :)

  1

  ---

  

  hagureshinma•135

  @hagureshinmaPosted almost 4 years ago

  Hello there MasterDev333! Thank you very much for sharing your insights. I followed your advice and tried to apply BEM conventions, i'll keep doing that for the upcoming projects :) Happy coding!

  0
• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted almost 4 years ago

  Hey, hagureshinma! 👋

  Congratulations on completing your first Frontend Mentor challenge! 🎉

  Great job on this one! 👏 Your solution looks good and the background images are nicely placed! 👍

  I only suggest perhaps adding a heading to the card component (such as for the name or something) to make your HTML a wee bit more semantic. You could even use the <article> tag for the whole component, then, too.

  Keep coding (and happy coding, as well)! 😁

  1

  ---

  

  hagureshinma•135

  @hagureshinmaPosted almost 4 years ago

  @ApplePieGiraffe Hi there! Thanks for you feedback, i took a look at the subject and tried to apply it. I'll have semantics in mind from here on.

  Happy coding!

  0