Submitted almost 4 years ago

Responsive profile card page with html & css

hagureshinma• 135

@hagureshinma

Preview site(opens in new window)View code(opens in new window)

This is a solution for...

Profile card component

HTML
CSS

1newbie

View challenge

Design comparison

SolutionDesign

Solution retrospective

This is my first project here, any feedback would be appreciated, specially about the optimization of my code.

Community feedback

Web Frog• 1,840

@MasterDev333

Posted almost 4 years ago

Great work! It's a little tricky to positioning background circles in this challenge, but you did it well. It would be better if you make your class names more readable. Please take a look BEM naming conventions if you have time. Hope it helps. Happy coding~ :)

hagureshinma• 135

@hagureshinma

Posted almost 4 years ago

Hello there MasterDev333! Thank you very much for sharing your insights. I followed your advice and tried to apply BEM conventions, i'll keep doing that for the upcoming projects :) Happy coding!

ApplePieGiraffe• 30,545

@ApplePieGiraffe

Posted almost 4 years ago

Hey, hagureshinma! 👋

Congratulations on completing your first Frontend Mentor challenge! 🎉

Great job on this one! 👏 Your solution looks good and the background images are nicely placed! 👍

I only suggest perhaps adding a heading to the card component (such as for the name or something) to make your HTML a wee bit more semantic. You could even use the <article> tag for the whole component, then, too.

Keep coding (and happy coding, as well)! 😁

hagureshinma• 135

@hagureshinma

Posted almost 4 years ago

@ApplePieGiraffe Hi there! Thanks for you feedback, i took a look at the subject and tried to apply it. I'll have semantics in mind from here on.

Happy coding!

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord