Responsive Profile Card

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted over 3 years ago

  👋 Hi Jonathan Lee! My name is Vanza!

  👍Good job, on finishing this challenge, especially you can handle the background-position on those two circles or bubbles.

  I have a feedback, I think you can remove the min-width since you have set the width:

  @media (max-width: 375px) {
    .card {
      width: 85%;
      min-width: 1rem;
    }
  }
  

  That's it! Hopefully that little tip is helpful for you!

  Marked as helpful

  2

  ---

  

  Jonathan Lee•375

  @jonathancklee1Posted over 3 years ago

  @vanzasetia

  Hi Vanza, Thank you for your feedback!

  In my head, I have set the min-width in my media query as an "override" because I have set a min-width of 19rem in my normal class, but I think it might not be a good practice?

  By removing the media query min-width, I realise that I could set the normal min-width to something lower and it works just fine to fit small phone screens.

  Thanks for pointing it out :)

  0
• 

  hassan ABD•865

  @hassanabd22Posted over 3 years ago

  Nice job, but the card could be made a little smaller

  0