@shashreesamuel
Posted
Hey good job completing this challenge.
Keep up the good work
Your solution looks great however I think that your card is missing a subtle box-shadow using box-shadow.
In terms of your accessibility issues simply wrap all your content between main tags.
I hope this helps
Cheers Happy coding 👍
@etiennedesfontaines
Posted
@TheCoderGuru Hi Shashree, Thank you for your feedback.
My card does however already have a box-shadow applied.
As for the accessibility issues, I feel apprehensive to wrap the background SVG images in my main tag, because semantically I do not think they warrant being represented by main.
As far as I've learned, <main> represents the dominant content of the body of a document. Its contents should directly expand upon the central topic of a document and be unique to that document.
In the case of this challenge, in my assessment, the central functionality is the profile card. I do not think the background beyond the actual profile card warrants being included in main.
Please share if my understanding is limited? I am always looking to learn more...
@etiennedesfontaines
Posted
p.s I managed to solve the accessibility issues by adding an aria role attribute with a value of "presentation" to the SVG's. So I think my reasoning re semantic HTML was sound... 🤷♂️
