Melvin Aguilar π§π»βπ»β’ 61,220
@MelvinAguilar
Posted
Hi @nurularifin83 π, good job completing this challenge! π
I have some suggestions you might consider to improve your code:
- Use
<footer>
instead of<div class="row footer">
. The<footer>
element contains authorship information.
- Once you update the footer container, the footer should be outside the main content.
- The background pattern is for decoration purposes only, so it can be hidden from screen-readers by adding
aria-hidden="true"
and leaving its alt attribute empty:
<img class="rounded-top-md card-img-top" src="src/media/patterns/bg-pattern-card.svg" alt aria-hidden="true">
- You can display the background image correctly by updating the path:
background: url(../media/patterns/bg-pattern-bottom.svg) bottom -600px right no-repeat, url(../media/patterns/bg-pattern-top.svg) top -500px left -200px no-repeat;
I hope those tips will help you! π
Good job, and happy coding! π
Marked as helpful
1
Nurul Arifinβ’ 310
@nurularifin83
Posted
@MelvinAguilar Thank you for your help Melvin, background image work now
1