Responsive Profile Card

Community feedback

• 

  T

  Grace•31,270

  @grace-snowPosted over 3 years ago

  Looks good, just check it on mobile landscape

  0

  ---

  

  T

  Grace•31,270

  @grace-snowPosted over 3 years ago

  There is a small issue that needs fixing on your html. It's important that headings go in order to give proper document structure (you can't jump from h1/2 to h5).

  But what you have as h5s at the moment don't make sense as headings. (eg would you understand 803k as a heading on a contents page? Probably not). Try making stats1 into paragraphs or list items within an unordered list, and then use spans to style the number and word separately. Semantically that would make sense.

  I hope this helps

  0

  

  Martina•20

  @marocttPosted over 3 years ago

  @grace-snow Thank you so much for taking the time to check the code and comment! I get what you're saying, I'll fix that and keep it in mind for next challenges! :)

  0
• 

  Jordy Tirado Torres•300

  @jordytiradotorresPosted over 3 years ago

  Me gusto mucho tu solución 🤙

  0

  ---

  

  Martina•20

  @marocttPosted over 3 years ago

  @jordytiradotorres 😊 Gracias!

  0
• 

  Luiz Claudio Lopes•505

  @lc-dev90Posted over 3 years ago

  overall looks really good!

  0

  ---

  

  Martina•20

  @marocttPosted over 3 years ago

  @lc-dev90 Thanks!! :)

  0