responsive product-preview-component

Community feedback

• 

  Adriano•38,390

  @AdrianoEscarabotePosted about 2 years ago

  Hi is real, how are you?

  Welcome to the front-end mentor community!

  I really liked the result of your project, but I have some tips that I think you will enjoy:

  • every Html document must contain the main tag, so we can identify the main content, to fix this, wrap all the content with the main tag. HTML5 landmark elements are used to improve navigation experience on your site for users of assistive technology.
  • To align some content in the center of the screen, always prefer to use display: flex; it will make the layout more responsive!

  Example:

  body {
      margin: 0;
      padding: 0;
      display: flex;
      align-items: center;
      justify-content: center;
      min-height: 100vh;
  }
  

  The rest is great!

  I hope it helps... 👍

  Marked as helpful

  1

  ---

  

  is real•200

  @isreal916Posted about 2 years ago

  @AdrianoEscarabote hi andriano thanks for your feed back

  1
• 

  Szabolcs•330

  @Szabolcs-ZegPosted about 2 years ago

  Hello!

  There are two errors in your code: 1: Google link for font-families are wrong in the html file. Change it from this official site: ie: https://fonts.google.com/specimen/Fraunces (For embedding use the link from the gray area on the left, instead of the website link.)

  2. You typed the font-family name incorrectly in the css. The good is "Fraunces", you wrote "fraunce"

  Happy coding!

  Marked as helpful

  0

  ---

  

  is real•200

  @isreal916Posted about 2 years ago

  @Szabolcs-Zeg thanks for your correction

  0
• 

  Mark•250

  @markskwidPosted about 2 years ago

  Hello, @isreal916

  If you are using an imported font you should wrap it by double quotation to use it. Example: font-family: "Fraunces", sans-serif;

  I also noticed that your HTML is not containing a level-one heading or <h1> the heading in this challenge is the name of the perfume.

  Marked as helpful

  0