Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive product-preview-card-component using CSS grid

@Himanshu-196018

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Give some review about my CSS. It would help me to improve my styling skills.

Community feedback

@nadezhda-frunza

Posted

Nice job! Your CSS is clear and readable, and you've used comments to describe the purpose of different sections, which is great for maintainability. Few recommendations:

  • Instead of using the @import method to load Google Fonts in your CSS, you might consider using the newer <link> method in the HTML <head> section to load fonts in a non-blocking manner. This can help improve page loading performance.
  • In your media query for screens with a minimum width of 700px, you have specified height: 450 - > you forgot the height property.(px)
  • Adding a transition property to the button. This way you can achieve a smoother background-color change.

Congrats on completing the challenge, keep it up!

Marked as helpful

0

@Himanshu-196018

Posted

@nadezhda-frunza Thank you for your useful suggestions. I will try to improve myself based on your suggestions and will try to include all the things you mentioned.

Thank you for giving your precious time for reviewing my solution.

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord