Skip to content
Submitted about 2 years ago

Responsive product-card-review

ioannis sofianos•30
@sof28
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Product preview card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • Lucas 👾•104,340
    @correlucasPosted about 2 years ago

    👾Hello @sof28, Congratulations on completing this challenge!

    Your solution its almost done and I’ve some tips to help you to improve it:

    1.Replace the <h3> containing the main title with <h1> note that this title is the main heading for this page and every page needs one h1 to show which is the most important heading. Use the sequence h1 h2 h3 h4 h5 to show the hierarchy of your titles in the level of importance, never jump a level.

    2.Add the correct font for the main heading of this component. First of all you need to choose the font using Google Fonts https://fonts.google.com/ and import the code to drop on your CSS/HTML:

    This is the font for the H1: font-family: 'Fraunces', serif;. There's two ways to import the font:

    • Using the html and inserting it to the <head>
    <head>
<link rel="preconnect" href="https://fonts.googleapis.com">
<link rel="preconnect" href="https://fonts.gstatic.com" crossorigin>
<link href="https://fonts.googleapis.com/css2?family=Fraunces:opsz,[email protected],700&display=swap" rel="stylesheet">
</head>
    • Using the CSS and adding to the first line of the CSS sheet:

    @import url('https://fonts.googleapis.com/css2?family=Fraunces:opsz,[email protected],700&display=swap');

    3.A better way to work this solution image, the product image is by using <picture> to wrap it on the html instead of using it as <img> or background-image (with the css). Using <picture> you wrap both images (desktop and mobile) and have more control over it, since you can set in the html when the images changes setting the screen size for each image.ote that for SEO / search engine reasons isn’t a better practice import this product image with CSS since this will make it harder to the image.

    Here’s the documentation and the guide to use this tag: https://www.w3schools.com/tags/tag_picture.asp

    See the example below:

    <picture>
  <source media="(max-width:650px)" srcset="./images/image-product-mobile.jpg">
  <img src="./images/image-product-desktop.jpg" alt="Gabrielle Parfum" style="width:auto;">
</picture>

    ✌️ I hope this helps you and happy coding!

    Marked as helpful
    1
    ioannis sofianos•30
    @sof28Posted about 2 years ago

    @correlucas thank you very much for the tips, they are very helpful and I'm going to make the changes ,you suggested.

    I really appreciated it and happy coding also to you !!

    1
  • Nikhil Sharma•340
    @NIk22517Posted about 2 years ago

    Hey @sof28, I'm impressed how much your first challenge is good the design is basically matching the figma files, amazing!

    Here's one tip for you:

    Replace <img> tag with <picture> tag

     <picture>
          <source
            srcset="mobile.jpg"
            media="(max-width: 620px)"
          />
          <img
            src="desktop.jpg"
            alt="Office Workers Smiling"
          />
        </picture>

    and add border-radius to the desktop-img

    img{
 border-radius: 0.5rem 0 0 0.5rem;
//border-radius: top-left top-right bottom-right bottom-left
}

**✌️ I hope this helps you and happy coding!**
    Marked as helpful
    0
    ioannis sofianos•30
    @sof28Posted about 2 years ago

    @NIk22517 , I appreciate the good words for my attempt, thank you for the comments on my job, they are very helpful for me , and I am going to make the changes , you suggested

    Happy coding also to you !!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord