Responsive Product Viewing Component

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted about 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • Decrease 📉 the width of the component to better match the FEM example.

  • The image’s Alt Tag description needs to be improved upon to better describe what it is. You will want to assume that you are describing the image to a someone.

  • This component requires the use of two images 🎑 at different breakpoints. The Picture element will facilitate this.

  Here is an example of how it works: EXAMPLE

  Syntax:

    <picture>
      <source media="(min-width: )" srcset="">
      <img src="" alt="">
    </picture>
  

  More Info:

  https://www.w3schools.com/html/html_images_picture.asp

  https://web.dev/learn/design/picture-element/

  • Currently, the old price (169.99) 🏷 is not being properly announced to screen readers. To fix this, you are going to wrap the the price in a Del Element and inside it you will add a Span Element with an sr-only class that will state something like “The previous price was…” and use CSS to make it only visible to screen readers.

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding! 🍂🦃

  Marked as helpful

  1

  ---

  

  Derrick Yew Choon Min•20

  @yewcm123Posted about 2 years ago

  @vcarames Hey there, thank you very much for your thorough explanation to improve upon my design. I really appreciate it :) I will amend my code based on your suggestions.

  0