Design comparison
SolutionDesign
Community feedback
- @halderjoydeepPosted over 2 years ago
Hi @shimul0022, Great work! But I would like to give you some suggestions-
- Use
display:block
for img. Then that little white space below the image will disappear. It will fit perfectly. - don't give margin for top and bottom. Setting margin bottom is good practice.
.written-content, .price, .cart, .attribution { margin-bottom: .8rem; }
Regarding margin, you can refer to this amazing post. You will understand how margin actually works and the concept of margin-collapse. https://www.joshwcomeau.com/css/rules-of-margin-collapse/
Marked as helpful1@shimul0022Posted over 2 years ago@halderjoydeep Thank you so much for your feedback. I will surely apply those asap.
0 - Use
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord