Skip to content
Submitted almost 2 years ago

Responsive Product review Card Component Using Grid and Flex

Muhammadh•1,140
@Mr-jaw
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Product preview card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

I'll be glad to hear any review about my deployment 😊

  1. Is there any Accessibility tweaks that i could improve?

  2. Any thing to improve in semantic HTML or CSS?

Community feedback

  • P. Ricardo•2,370
    @pRicard0Posted almost 2 years ago

    In the HTML you used the P elements to represent the prices. There are more semantic choices. There is the em tag that is used when you want to emphasize something. There is the s tag which means strikethrough, which is used when you want to say something that is no longer relevant. You probably forgot to use the footer tag for the div with class "attribution"

    In CSS you probably forgot to use cursor: pointer for when the cursor is over the button.

    1
    Muhammadh•1,140
    @Mr-jawPosted almost 2 years ago

    @pRicard0 Thanks for the review ❤️

    yes, i forgot the footer tag. and also the pointer. i'll improve myself in future

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord