Responsive product review card

Community feedback

• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hello Faith, Congratulations on completing this challenge!

  Your solution its almost done and I’ve some tips to help you to improve it:

  Use the THE PICTURE TAG that is a shortcut to deal with the multiple images in this challenge. So you can use the <picture> tag instead of importing this as an <img> or using a div with background-image. Use it to place the images and make the change between mobile and desktop, instead of using a div or img and set the change in the css with display: none with the tag picture is more practical and easy. Note that for SEO / search engine reasons isn’t a better practice import this product image with CSS since this will make it harder to the image. Manage both images inside the <picture> tag and use the html to code to set when the images should change setting the device max-width depending of the device desktop + mobile.

  Check the link for the official documentation for <picture> in W3 SCHOOLS: https://www.w3schools.com/tags/tag_picture.asp

  See the example below:

  <picture>
    <source media="(max-width:650px)" srcset="./images/image-product-mobile.jpg">
    <img src="./images/image-product-desktop.jpg" alt="Gabrielle Parfum" style="width:auto;">
  </picture>
  

  👨‍💻Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/product-preview-card-vanilla-css-and-custom-hover-state-on-hero-dVGWpOTgWS

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  0
• 

  Spencer Rafada•130

  @spencer-rafadaPosted about 2 years ago

  Hello Faith,

  I suggest using BEM notation for the naming convention of the CSS classes. I learned this from one of my feedbacks here in FEM. Also, I think you should explore on learning CSS Grids for setting up the layouts of the view. It is a lot easier to line up all of the components with CSS Grids. I found this trick for using CSS and HTML only for the interactivity of the image depending on the screen size. https://stackoverflow.com/questions/27853884/media-queries-and-image-swapping

  Overall, keep learning and practicing!

  Marked as helpful

  0