Design comparison
SolutionDesign
Community feedback
- @kimodev1990Posted 11 months ago
Great work in completing the challenge, Just a few feedbacks :
- It better ( here & future designs ) to assign percentage values instead of definite values, such as you could assign width of image and class .content width: 50% ; for each of them, so you it would be in relevant to the main container's width and having better responsiveness.
- You could center your design in middle of the website by adding in body :
display: flex ; justify-content: center ; align-items: center ; min-height: 100vh ;
then container under body will be centered, no need to use
top: 120px ;
&left: 28% ;
- Wrap the page's whole content in the <main> tag.
- Use font-size in rem or em units rather than pixels for better responsiveness
- You could use clamp ( ) method in your coding for font-size, width, margins, padding, etc., So the designed sizes will change according to the viewport dimensions having a responsive design and will be suitable for any device layout.
Hope you find this Helpful.
Other than that, Really Nice work & keep Going on.
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord