Responsive product preview using flexbox

Community feedback

• 

  faizan•2,420

  @afaiz-spacePosted about 2 years ago

  hey, @kiersten-c congratulation on completing the challenge.

  • add min-height:100vh in the body element,.
  • remove the left and right margins from the p and h elements. after add .content class with padding: 2rem;
  • add align-items: center; in the .price class.
  • you can do button width: 100%;

  . . keep it up

  1
• 

  バレンタイン 😈•64,170

  @VCaramesPosted about 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  Regarding mobile first approach,

  Its the same thing as desktop -> mobile, the only difference is that your are now creating the mobile first and desktop last.

  The more you practice, the easier it gets. I used to create all my sites desktop first, but once I got the hang of mobile-first it became second nature.

  • To better identify the main content of you site you will want to encase your entire component inside a Main Element.

  • The Alt Tag Description for the image needs to be improved upon. You want to describe what the image is; they need to be readable. Assume you’re describing the image to someone.

  • This challenges requires the use of two images 🎑 for different breakpoints. The Picture Element will facilitate this.

  Here is an example of how it works: EXAMPLE

  Syntax:

    <picture>
      <source media="(min-width: )" srcset="">
      <img src="" alt="">
    </picture>
  

  More Info:

  https://www.w3schools.com/html/html_images_picture.asp

  https://web.dev/learn/design/picture-element/

  • The only heading in this challenge is the name of the perfume, “Gabrielle Essence Eau De Parfum” . The rest of the text should be wrapped in a Paragraph Element.

  If you have any questions or need further clarification, let me know.

  Happy Coding! 👻🎃

  0