Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive product preview using CSS and HTML

@BassemNegm

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


And feedback is very appreciated..

Community feedback

yas 390

@yosrajalali

Posted

Hi Bassem 👋. Congratulations on successfully completing the challenge!🎉

just a couple of suggestions

HTML

  • for your whole container it's better to use <main> tag instead of a <div>.main tag is an HTML5 tag which is supposed to represent the main content of website. it's better for SEO purposes. you can check this 👉MDN

CSS

  • if you want to center the whole content of your page horizontally and vertically using display flex for body is the best choice, like the code below..
body {
min-height: 100vh;
display: flex;
align-items: center;
justify-content: center;
}
  • (*) is a universal selector and it is used to give universal styles to all elements. if you use font-weight and background-color in this universal selector it means that it gets apply to all elements of the page. try to do this..
body {
font-weight: 300;
background-color: rgb(227, 224, 224);
}

Anyway your solution is great🙂

I hope you find it useful😊

Marked as helpful

1

@BassemNegm

Posted

@yosrajalali Thank you so much for your feedback, and I love how simple you explained it. I'll definitely use what you suggested in my upcoming codes.

1
yas 390

@yosrajalali

Posted

I’m glad to hear that..

good luck🌹 @BassemNegm

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord