@mason-dunn
Posted
Hi HaYeong,
I love the way you organize your files!
I did notice while looking through your code that you have a tendency to use <div> a lot. Learning semantic HTML could provide a lot of readability and even cut down on some unnecessary styling sometimes.
For example, for the original price of the item ($169.99), the <del> tag automatically puts a line-through text decoration style and the tag itself tells the browser that the data in that tag is "removed."
Another example would be for the headings of this component. By using H1-H6 tags you can avoid using font-weight and tell the browser what the main content is. In your code you used <p> tags for product and category.
Lastly, for your button you didn't use the <button> tag. Using the <button> tag makes sense because it is an element that is meant to be interacted with. Of course the user knows that, but the browser won't know that.
Good work on completing this challenge :)
Mason Dunn
Marked as helpful
@hypyeon
Posted
@mason-dunn Thank you so much for taking your time and reviewing my codes! I really appreciate your feedback. I'm on my way to fix those as advised! :)