Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive Product preview components

@mryjybrcia

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Please let me know what I can improve with my codes. Thank you!

Community feedback

@NikNT

Posted

Hey @mryjybrcia Nice work.

There are some points that I would like to suggest -

  • Ensures that you follow semantic markup in your code. At present, you have only leveraged <div> throughout the markup. Try to incorporate semantic markup.

  • Always make sure that you have at least an <h1> in the markup. It defines the primary title of the page. I didn't observe any <h1> in your current code.

  • The image is missing 'alt'.

  • You have kept the attribution styling in HTML file, which is okay. But to structure your code better, keep all your styling within one file. Neat and clean.

  • The zoom-in animation that you added to the image looks nice, feels great.

  • On the button, you have missed adding the 'cart' icon.

  • The heading 'Perfume' needs to be capitalized with a bit of word-spacing 'P E R F U M E'

  • To make the design more accurate, you can increase the font-size for the name of perfume, increase the width of overall card, and stretch the details while providing some line-spacing.

Let me know if you want help in any of these. I'll be happy to help.

Keep Coding!

NT

0

@mryjybrcia

Posted

Thank you @NikNT ! I appreciate all your pointers. :)

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord