Responsive product preview component using CSS Flexbox

Community feedback

• 

  romila•3,570

  @romila2003Posted over 2 years ago

  Hi Mohammed,

  Congratulations 🎉on your completing your second challenge. It was a great attempt and it's good you are becoming familiar with media queries, especially at an early stage.

  Regarding your media queries, it looks great however it is great practice to take a mobile approach first since it will be easier to adjust the elements as the screen size change in comparison to desktop approach first. There are many resources explaining the benefits of mobile first and how to implement this strategy into your project. When the screen reaches 765px, the card becomes too big for the screen therefore it would not look appealing for users using this screen size. It is good that you used the main tag for your card however another suggestion is to give the element a class of container or something similar e.g. <main class="container></main

  Overall, it was a great attempt and wish you success for your future projects 👍.

  Hope you found this helpful and if so, mark it as helpful.

  Marked as helpful

  1

  ---

  

  Mohammed Zakaria Khan•180

  @zaks276Posted over 2 years ago

  @romila2003 Thank you for the feedback

  1