Design comparison
Solution retrospective
Any feedback will be appreciated and also I'm looking for mentor :)
Community feedback
- @correlucasPosted over 2 years ago
πΎHello Christian, congratulations for your solution!
Your solution seems pretty good and your design elements are fine too!
Note that theres only a little issue when your component scale downs around
1000px
the image in the left column, doesnt fit the container column, you can fix that withimg {max-width: 100%; display: block;
or a quick fix using themedia query
a little bit earlier to have the container vertically (best choice).Hope it helps and happy coding bro!
1 - @muhammaduzair11Posted over 2 years ago
I spend some time looking into your solution. I have found some problems.
- Your solution is not responsive.
- In tablet view, there is not enough white space
- In the mobile view, it almost gets out from the container.
- Spend some time learning media queries.
- I would suggest watching tutorials on responsive web design.
- It will help you learn responsive design
(If my my feedback helped you PLEASE mark it as helpful)
0@vanzasetiaPosted over 2 years ago@muhammaduzair11
Hey, Muhammad Uzair! Next time, avoid asking the solution author to mark your comment as helpful. It is against one of the community guidelines. Also, it places unnecessary pressure on the solution author to mark the comment as helpful.
The idea is to give people feedback to offer helpful support without the expectation of anything. If the solution author does mark your comment as helpful, then it's a nice bonus. π
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord