Design comparison
Solution retrospective
What did you find difficult while building the project? Which areas of your code are you unsure of? Do you have any questions about best practices?
Community feedback
- @VCaramesPosted about 2 years ago
Hey @MXalman, some suggestions to improve you code:
- Implement a Mobile First approach 📱 > 🖥
With mobile devices being the predominant way that people view websites/content. It is more crucial than ever to ensure that your website/content looks presentable on all mobile devices. To achieve this, you start building your website/content for smaller screen first and then adjust your content for larger screens.
- To give you HTML code structure, you want to set up your code in the following manner (only did parent containers):
<body> <main> <article class=“card-container”> <picture></picture> <div class="card-content"> </div> </article> </main> </body>
The Main Element identifies the main content of the document.
While the Article Element will serve as the card’s container, because the card represents a complete, or self-contained, section of content that is, in principle, independently reusable.
More info:
https://web.dev/learn/html/headings-and-sections/
-
The Alt Tag Description for the image needs to be improved upon. You want to describe what the image is; they need to be readable. Assume you’re describing the image to someone.
-
This challenges requires the use of two images 🎑 for different breakpoints. The Picture Element will facilitate this.
Here is an example of how it works: EXAMPLE
Syntax:
<picture> <source media="(min-width: )" srcset=""> <img src="" alt=""> </picture>
**More Info: **
https://www.w3schools.com/html/html_images_picture.asp
https://web.dev/learn/design/picture-element/
- You are using fixed properties for you content, you want to instead use responsive properties to make your content fully responsive to multiple screen sizes not just two.
Happy Coding! 👻🎃
Marked as helpful1@MXalmanPosted about 2 years ago@vcarames Thank you! I will definitely follow your suggestions.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord