Responsive Product Preview Card with SASS

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  iMAGES 📸:

  • alt text is a descriptive text attribute added to an HTML image tag that provides a textual description of an image for users who are visually impaired or cannot see the image for any other reason.

  ---

  • The purpose of alt text is to convey the meaning and context of an image to these users so that they can understand the content and information conveyed by the image.

  ---

  • But here, The svg's are just used as a decoration material.

  ---

  • Meanwhile it also needs an alt attribute with empty value

  ---

  • Eg: <img src="./images/icon-cart.svg" alt="" aria-hidden="true">

  ---

  HEADINGS ⚠️:

  • This solution has generated accessibility error report due to skipping heading levels

  ---

  • We want to avoid skipping heading levels, make sure to start with <h1> and working your way down the heading levels (<h2>, <h3>, etc.) helps ensure that our document has a clear and consistent hierarchy. Read more 📚

  ---

  • Because skipping heading levels is a poor practice from the perspective of information design, whether we are talking about web pages, books, journal articles, or about anything else. You can not only confuse screen readers but all readers when you don't follow a consistent, logical pattern with your heading structure.

  ---

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  0