Responsive product preview card using picture element.
Design comparison
Solution retrospective
Hey folks, I have completed this challenge by using picture element to make this responsive for desktop and as well as mobile.
I am always open to feedback.
Please let me know if anything lacking in my solution.
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
COMPONENT MEASUREMENTS 📐:
- The
width: 100vw
property formain
element is not necessary. because it's a block level element which will take the full width of the page by default.
- Use
min-height: 100vh
formain
instead ofheight: 100vh
. Setting theheight: 100vh
may result in the component being cut off on smaller screens, such as mobile devices in landscape orientation.
- For example; if we set
height: 100vh
then themain
will have100vh
height no matter what. Even if the content spans more than100vh
of viewport.
- But if we set
min-height: 100vh
then themain
will start at100vh
, if the content pushes themain
beyond100vh
it will continue growing. However if you have content that takes less than100vh
it will still take100vh
in space.
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
Marked as helpful0 - @eddybproPosted over 1 year ago
Hi, PriyanshuPrama12
Congratulation on finishing this challenge, I hope it was fun. Here are some suggestions to improve the code:
- CSS code:
#product button { /*update 'width' property/ width: 100%; /*add 'padding' property*/ padding: .625rem 0; /*remove 'height' property*/ }
Remember to use relative units
rem em
instead of absolute unitspx
.That's it, Happy coding
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord