Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive product preview card using picture element.

@Priyanshu-WD

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hey folks, I have completed this challenge by using picture element to make this responsive for desktop and as well as mobile.

I am always open to feedback.

Please let me know if anything lacking in my solution.

Community feedback

@0xabdulkhaliq

Posted

Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

COMPONENT MEASUREMENTS 📐:

  • The width: 100vw property for main element is not necessary. because it's a block level element which will take the full width of the page by default.
  • Use min-height: 100vh for main instead of height: 100vh. Setting the height: 100vh may result in the component being cut off on smaller screens, such as mobile devices in landscape orientation.
  • For example; if we set height: 100vh then the main will have 100vh height no matter what. Even if the content spans more than 100vh of viewport.
  • But if we set min-height: 100vh then the main will start at 100vh, if the content pushes the main beyond 100vh it will continue growing. However if you have content that takes less than 100vh it will still take 100vh in space.

.

I hope you find this helpful 😄 Above all, the solution you submitted is great !

Happy coding!

Marked as helpful

0

@Priyanshu-WD

Posted

Thank you for your feedback@0xAbdulKhalid

0

@eddybpro

Posted

Hi, PriyanshuPrama12

Congratulation on finishing this challenge, I hope it was fun. Here are some suggestions to improve the code:

  • CSS code:
#product button {
/*update 'width' property/
width: 100%;
/*add 'padding' property*/
padding: .625rem  0;
/*remove 'height' property*/
}

Remember to use relative units rem em instead of absolute units px.

That's it, Happy coding

Marked as helpful

0

@Priyanshu-WD

Posted

Thank you for your feedback@eddybpro

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord