Responsive product preview card using HTML, CSS, CSS-Grid
Design comparison
Solution retrospective
How do I better switch between grid-row layout and grid-column layout?
Community feedback
- @NIk22517Posted about 2 years ago
Hey @Chidisunday2, I'm impressed how much your first challenge is good the desing is basically matching the Figma files, amazing!
Here's one tip for you:
You have used
background-image
instead of usingbackground-image
you can use<picture> <source srcset="mobile.jpg" media="(max-width: 620px)" /> <img src="desktop.jpg" alt="Office Workers Smiling" /> </picture>
✌️ I hope this helps you and happy coding!
Marked as helpful1 - @correlucasPosted about 2 years ago
👾Hello @Chidisunday2, Congratulations on completing this challenge!
Your solution its almost done and I’ve some tips to help you to improve it:
Think about using relative units as
rem
orem
instead ofpx
to improve your performance by resizing fonts between different screens and devices. Anyhow, if we want a more accessible website, then we should use rem instead of px. REM does not just apply to font size, but to all sizes as well.Using
<picture>
you’ve more control over the elements and its better than using the product image as<img>
orbackground-image
. Look that for SEO and search engine reasons it isn't a better practice to import this product image with CSS since this will make it harder to the image. You can manage both images inside the<picture>
tag and use the html to code to set when the images should change setting the devicemax-width
depending of the device (phone / computer) Here’s a guide about how to usepicture
:https://www.w3schools.com/tags/tag_picture.asp
✌️ I hope this helps you and happy coding!
Marked as helpful0@Chidisunday2Posted about 2 years ago@correlucas thanks for your input, this is Helpful
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord