Responsive product preview card using HTML, CSS, CSS-Grid

Community feedback

• 

  Nikhil Sharma•340

  @NIk22517Posted about 2 years ago

  Hey @Chidisunday2, I'm impressed how much your first challenge is good the desing is basically matching the Figma files, amazing!

  Here's one tip for you:

  You have used background-image instead of using background-image you can use

  <picture>
            <source
              srcset="mobile.jpg"
              media="(max-width: 620px)"
            />
            <img
              src="desktop.jpg"
              alt="Office Workers Smiling"
            />
          </picture>
  

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  1

  ---

  

  Okoroafor Chidiebere•80

  @Chidisunday2Posted about 2 years ago

  @NIk22517 thank you for your input

  0
• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hello @Chidisunday2, Congratulations on completing this challenge!

  Your solution its almost done and I’ve some tips to help you to improve it:

  Think about using relative units as rem or em instead of px to improve your performance by resizing fonts between different screens and devices. Anyhow, if we want a more accessible website, then we should use rem instead of px. REM does not just apply to font size, but to all sizes as well.

  Using <picture> you’ve more control over the elements and its better than using the product image as <img> or background-image. Look that for SEO and search engine reasons it isn't a better practice to import this product image with CSS since this will make it harder to the image. You can manage both images inside the <picture> tag and use the html to code to set when the images should change setting the device max-width depending of the device (phone / computer) Here’s a guide about how to use picture: https://www.w3schools.com/tags/tag_picture.asp

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  0

  ---

  

  Okoroafor Chidiebere•80

  @Chidisunday2Posted about 2 years ago

  @correlucas thanks for your input, this is Helpful

  1