Responsive product preview card using flex-box and css

Community feedback

• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hello @StigAkl, Congratulations on completing this challenge!

  Your solution its almost done and I’ve some tips to help you to improve it:

  Use the THE PICTURE TAG that is a shortcut to deal with the multiple images in this challenge. So you can use the <picture> tag instead of importing this as an <img> or using a div with background-image. Use it to place the images and make the change between mobile and desktop, instead of using a div or img and set the change in the css with display: none with the tag picture is more practical and easy. Note that for SEO / search engine reasons isn’t a better practice import this product image with CSS since this will make it harder to the image. Manage both images inside the <picture> tag and use the html to code to set when the images should change setting the device max-width depending of the device desktop + mobile.

  Check the link for the official documentation for <picture> in W3 SCHOOLS: https://www.w3schools.com/tags/tag_picture.asp

  See the example below:

  <picture>
    <source media="(max-width:650px)" srcset="./images/image-product-mobile.jpg">
    <img src="./images/image-product-desktop.jpg" alt="Gabrielle Parfum" style="width:auto;">
  </picture>
  

  👨‍💻Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/product-preview-card-vanilla-css-and-custom-hover-state-on-hero-85A1JsueD1

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  0
• 

  Husam Asaad•420

  @husamasaadPosted about 2 years ago

  Hi @StigAkl, You did a great job Sir.

  I had a similar problem when I did this challenge, and there is an amazing guy commented and advised me to use <picture> tag instead of using background-image in an empty div.

  In your images you were provided with two images one for mobile and the other is for the Desktop, using the picture in html file allows you to put both images and the screen size will determine which to show.

  plus I think it would be better if you sit the max-width in your @media to 767px and leave the bigger screen with the flex-direction of row.

  take a look at how I did this challenge and read the comment about the Picture tag it is very helpful...Happy coding journey.

  here is my solution

  Marked as helpful

  0

  ---

  

  Stig•40

  @StigAklPosted about 2 years ago

  @husamasaad Thank you for your feedback! I had a look at your solution as well. Cool to see that we have somewhat equal solution when using flexboxes :)

  0